Squidex Client Library - GetAsync removed from SquidexClient?

blakecodes · August 19, 2019, 6:37pm

I’m submitting a…

[ X ] Regression (a behavior that stopped working in a new release)
[ ] Bug report
[ ] Performance issue
[ ] Documentation issue or request

Current behavior

It seems that the filter parameter has been removed on the GetAsync call for Squidex client. This is also another major breaking change for us.

Expected behavior

Can this be added back?

Minimal reproduction of the problem

github.com

Squidex/squidex-samples/blob/6fc058d73774b4f2fb69fb954b4ce67054f0dea2/csharp/Squidex.ClientLibrary/Squidex.ClientLibrary/SquidexClient.cs#L46


    var response = await RequestJsonAsync<GraphQlResponse<TResponse>>(HttpMethod.Post, $"content/{ApplicationName}/graphql", request.ToContent(), context, ct);


    if (response.Errors?.Length > 0)
    {
        throw new SquidexGraphQlException(response.Errors);
    }


    return response.Data;
}


public Task<SquidexEntities<TEntity, TData>> GetAsync(ODataQuery query = null, QueryContext context = null, CancellationToken ct = default)
{
    var q = query?.ToQuery(true) ?? string.Empty;


    return RequestJsonAsync<SquidexEntities<TEntity, TData>>(HttpMethod.Get, BuildContentUrl(q), null, context, ct);
}


public Task<TEntity> GetAsync(string id, QueryContext context = null, CancellationToken ct = default)
{
    Guard.NotNullOrEmpty(id, nameof(id));

Environment

[ ] Self hosted with docker
[ X ] Self hosted with IIS
[ ] Self hosted with other version
[ ] Cloud version

Sebastian · August 19, 2019, 7:32pm

it is part of the OData query object because I wanted to reduce the number of parameters.

Sebastian · August 19, 2019, 7:47pm

Sorry for the inconviences today, I hope it solves your problem.