[SOLVED] Restore shows deleted schemas

davecroll · January 17, 2019, 6:16pm

I’m submitting a…

[ ] Regression (a behavior that stopped working in a new release)
[ X ] Bug report
[ ] Performance issue
[ ] Documentation issue or request

Current behavior

After restoring from a backup, deleted schemas are listed along side current schemas

Expected behavior

Deleted schemas don’t show up after running restore

Minimal reproduction of the problem

export from cloud instance
restore cloud backup on locally hosted instance ( )

Environment

[ X ] Self hosted with docker
[ ] Self hosted with IIS
[ ] Self hosted with other version
[ X ] Cloud version

Browser:

[ ] Chrome (desktop)
[ ] Chrome (Android)
[ ] Chrome (iOS)
[ ] Firefox
[ ] Safari (desktop)
[ ] Safari (iOS)
[ ] IE
[ ] Edge

Others:
previously deleted schemas shown in red.

Sebastian · January 17, 2019, 10:33pm

Thank you, it looks like an easy fix:

github.com

Squidex/squidex/blob/master/src/Squidex.Domain.Apps.Entities/Schemas/BackupSchemas.cs#L39


{
    Guard.NotNull(grainFactory, nameof(grainFactory));


    this.grainFactory = grainFactory;
}


public override Task<bool> RestoreEventAsync(Envelope<IEvent> @event, Guid appId, BackupReader reader, RefToken actor)
{
    switch (@event.Payload)
    {
        case SchemaCreated schemaCreated:
            schemasByName[schemaCreated.SchemaId.Name] = schemaCreated.SchemaId.Id;
            break;
    }


    return TaskHelper.True;
}


public override async Task RestoreAsync(Guid appId, BackupReader reader)
{
    await grainFactory.GetGrain<ISchemasByAppIndex>(appId).RebuildAsync(schemasByName);

I have to handle the deleted-event there.

like here:

github.com

Squidex/squidex/blob/master/src/Squidex.Domain.Apps.Entities/Rules/BackupRules.cs#L44


    this.grainFactory = grainFactory;
}


public override Task<bool> RestoreEventAsync(Envelope<IEvent> @event, Guid appId, BackupReader reader, RefToken actor)
{
    switch (@event.Payload)
    {
        case RuleCreated ruleCreated:
            ruleIds.Add(ruleCreated.RuleId);
            break;
        case RuleDeleted ruleDeleted:
            ruleIds.Remove(ruleDeleted.RuleId);
            break;
    }


    return TaskHelper.True;
}


public override async Task RestoreAsync(Guid appId, BackupReader reader)
{
    await grainFactory.GetGrain<IRulesByAppIndex>(appId).RebuildAsync(ruleIds);

Sebastian · January 19, 2019, 6:26pm

I pushed a commit with a fix, you can test the current dev-version

Sebastian · February 2, 2019, 7:07pm