[SOLVED] Impossible to use ',' button when entering tags

Aahz · June 18, 2024, 7:25am

I have…

Checked the logs and have uploaded a log file and provided a link because I found something suspicious there. Please do not post the log file in the topic because very often something important is missing.

I’m submitting a…

Regression (a behavior that stopped working in a new release)
Bug report
Performance issue
Documentation issue or request

Current behavior

When I press ‘,’ button Tag finises independent of my keyboard language layout

Expected behavior

Tag should be finished only when symbol ‘,’ entered not ‘,’ button is pressed.
It’s a problem when use non-USA keyboard layout.

Minimal reproduction of the problem

Environment

Self hosted with docker
Self hosted with IIS
Self hosted with other version
Cloud version

Version: [7.9]

Browser:

Chrome (desktop)
Chrome (Android)
Chrome (iOS)
Firefox
Safari (desktop)
Safari (iOS)
IE
Edge

Sebastian · June 18, 2024, 5:14pm

I am from Germany, so I am non-US and I have no idea what you are talking about

Aahz · June 19, 2024, 5:21am

I’m using Romanian and Ukranian keyboard layout and on ‘,’ button are set another symbols. But when I try to type it, Tag is ending instead of new symbol.

Sebastian · June 19, 2024, 10:04am

I have seen that I handle key code and key:

github.com

Squidex/squidex/blob/master/frontend/src/app/framework/utils/keys.ts#L35


      
          
          export function isControl(event: KeyboardEvent) {
              const key = event.key?.toUpperCase();
          
              return key === 'CONTROL' || event.keyCode === ALT;
          }
          
          export function isComma(event: KeyboardEvent) {
              const key = event.key?.toUpperCase();
          
              return key === ',' || event.keyCode === COMMA;
          }
          
          export function isDelete(event: KeyboardEvent) {
              const key = event.key?.toUpperCase();
          
              return key === 'DELETE' || event.keyCode === DELETE;
          }
          
          export function isEnter(event: KeyboardEvent) {
              const key = event.key?.toUpperCase();

I created a fiddle. Can you verify that this is the actual problem?

Aahz · June 25, 2024, 7:01am

When i use KEY OR CODE and press ‘б’ symbol (situated on ‘,’ key) I see message in console.
When i use KEY ONLY and press ‘б’ symbol (situated on ‘,’ key) nothing happens.
I think than key only is a correct behavior.

Sebastian · June 25, 2024, 7:01am

Thanks a lot. I will provide a fix asap.