[IMPLEMENTED] Enhanced controls on assets

Separate · March 6, 2020, 12:28am

It would be amazing to have enhanced controls on assets.

My issue right now is I’d like to be able to choose if an asset reference link should be displayed in the browser or downloaded. I’m finding that Squidex is setting the Content-Disposition header to attachment; filename="somefile.mp3"; filename*=UTF-8''somefile.mp3 which prompts the browser to download the file rather than play it in the browser.

Also being able to configure the Content-Type header for assets would be a nice feature to have.

Thanks as always

Sebastian · March 6, 2020, 6:46am

This is independent from the content type, I can change this behavior.

It is just this line:

github.com

Squidex/squidex/blob/master/backend/src/Squidex/Areas/Api/Controllers/Assets/AssetContentController.cs#L167


                    await ResizeAsync(asset, bodyStream, resizedAsset, fileVersion, resizeOptions, false);
                }
            }
        }
        else
        {
            await assetFileStore.DownloadAsync(asset.Id, fileVersion, bodyStream);
        }
    });


    if (query.Download == 1 || asset.Type != AssetType.Image)
    {
        return new FileCallbackResult(asset.MimeType, asset.FileName, true, handler);
    }
    else
    {
        return new FileCallbackResult(asset.MimeType, null, true, handler);
    }
}


private async Task ResizeAsync(IAssetEntity asset, Stream bodyStream, string fileName, long fileVersion, ResizeOptions resizeOptions, bool overwrite)

Sebastian · March 6, 2020, 10:05am

I have changed the behavior to always serve the file without an attachment name.

Separate · March 7, 2020, 5:19pm

Thanks for the quick change. This does achieve what I requested.

However I’m concerned that the removal of filename information from the headers is a significant loss of metadata. If a visitor tries to save an asset to their computer, the default filename is now the GUID instead of the actual filename.

I think setting the Content-Disposition to inline and including the attachment name would allow the assets to be loaded by the browser while providing the filename metadata if the visitor wants to download the file.

Sebastian · March 8, 2020, 7:52am

Make sense, I was not aware that there are different types

Sebastian · May 8, 2020, 7:42am